lkml.org 
[lkml]   [2023]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 10/11] KVM: riscv: selftests: Skip some registers set operation
    On Thu, May 25, 2023 at 03:38:34PM +0800, Haibo Xu wrote:
    > Set operation on some riscv registers(mostly pesudo ones) was not
    > supported and should be skipped in the get-reg-list test. Just
    > reuse the rejects_set utilities to handle it in riscv.
    >
    > Signed-off-by: Haibo Xu <haibo1.xu@intel.com>
    > ---
    > tools/testing/selftests/kvm/get-reg-list.c | 20 +++++++++++++-------
    > 1 file changed, 13 insertions(+), 7 deletions(-)
    >
    > diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing/selftests/kvm/get-reg-list.c
    > index f1fc113e9719..ebd6b580b33b 100644
    > --- a/tools/testing/selftests/kvm/get-reg-list.c
    > +++ b/tools/testing/selftests/kvm/get-reg-list.c
    > @@ -211,16 +211,22 @@ static void run_test(struct vcpu_reg_list *c)
    > ++failed_get;
    > }
    >
    > - /* rejects_set registers are rejected after KVM_ARM_VCPU_FINALIZE */
    > + /*
    > + * rejects_set registers are rejected after KVM_ARM_VCPU_FINALIZE on aarch64,
    > + * or registers that should skip set operation on riscv.
    > + */
    > for_each_sublist(c, s) {
    > if (s->rejects_set && find_reg(s->rejects_set, s->rejects_set_n, reg.id)) {
    > reject_reg = true;
    > - ret = __vcpu_ioctl(vcpu, KVM_SET_ONE_REG, &reg);
    > - if (ret != -1 || errno != EPERM) {
    > - printf("%s: Failed to reject (ret=%d, errno=%d) ", config_name(c), ret, errno);
    > - print_reg(config_name(c), reg.id);
    > - putchar('\n');
    > - ++failed_reject;
    > + if ((reg.id & KVM_REG_ARCH_MASK) == KVM_REG_ARM64) {
    > + ret = __vcpu_ioctl(vcpu, KVM_SET_ONE_REG, &reg);
    > + if (ret != -1 || errno != EPERM) {
    > + printf("%s: Failed to reject (ret=%d, errno=%d) ",
    > + config_name(c), ret, errno);
    > + print_reg(config_name(c), reg.id);
    > + putchar('\n');
    > + ++failed_reject;
    > + }
    > }
    > break;
    > }
    > --
    > 2.34.1
    >

    Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

    \
     
     \ /
      Last update: 2023-05-25 18:42    [W:6.576 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site