lkml.org 
[lkml]   [2023]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table
Hi Hans,

On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote:
> On 12/05/2023 18:35, Krzysztof Kozlowski wrote:
> > On 12/03/2023 14:12, Krzysztof Kozlowski wrote:
> >> The driver can match only via the DT table so the table should be always
> >> used and the of_match_ptr does not have any sense (this also allows ACPI
> >> matching via PRP0001, even though it might not be relevant here).
> >>
> >> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >
> > Hans, Sakari,
> >
> > Can you pick up the patchset? There was positive feedback:
> > https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/
> >
> > but it seems it was not applied.
>
> I see it is delegated to Sakari in patchwork and marked Under Review, but I don't
> see a corresponding pull request for this series.
>
> Sakari, did something go wrong?

I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for
this --- I intended to take these but I think I must have missed something
important in the process. I'll take them now.

Thanks.

--
Kind regards,

Sakari Ailus

\
 
 \ /
  Last update: 2023-05-25 14:40    [W:0.173 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site