lkml.org 
[lkml]   [2023]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.3 60/67] drm/msm: Be more shouty if per-process pgtables aren't working
    Date
    From: Rob Clark <robdclark@chromium.org>

    [ Upstream commit 5c054db54c43a5fcb5cc81012361f5e3fac37637 ]

    Otherwise it is not always obvious if a dt or iommu change is causing us
    to fall back to global pgtable.

    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Patchwork: https://patchwork.freedesktop.org/patch/537359/
    Link: https://lore.kernel.org/r/20230516222039.907690-2-robdclark@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/msm_iommu.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c
    index c2507582ecf34..0d6a69cd6f7a5 100644
    --- a/drivers/gpu/drm/msm/msm_iommu.c
    +++ b/drivers/gpu/drm/msm/msm_iommu.c
    @@ -234,7 +234,12 @@ struct msm_mmu *msm_iommu_pagetable_create(struct msm_mmu *parent)
    /* Get the pagetable configuration from the domain */
    if (adreno_smmu->cookie)
    ttbr1_cfg = adreno_smmu->get_ttbr1_cfg(adreno_smmu->cookie);
    - if (!ttbr1_cfg)
    +
    + /*
    + * If you hit this WARN_ONCE() you are probably missing an entry in
    + * qcom_smmu_impl_of_match[] in arm-smmu-qcom.c
    + */
    + if (WARN_ONCE(!ttbr1_cfg, "No per-process page tables"))
    return ERR_PTR(-ENODEV);

    /*
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-05-25 22:39    [W:4.095 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site