lkml.org 
[lkml]   [2023]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 30/31] atm: hide unused procfs functions
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit fb1b7be9b16c1f4626969ba4e95a97da2a452b41 ]

    When CONFIG_PROC_FS is disabled, the function declarations for some
    procfs functions are hidden, but the definitions are still build,
    as shown by this compiler warning:

    net/atm/resources.c:403:7: error: no previous prototype for 'atm_dev_seq_start' [-Werror=missing-prototypes]
    net/atm/resources.c:409:6: error: no previous prototype for 'atm_dev_seq_stop' [-Werror=missing-prototypes]
    net/atm/resources.c:414:7: error: no previous prototype for 'atm_dev_seq_next' [-Werror=missing-prototypes]

    Add another #ifdef to leave these out of the build.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20230516194625.549249-2-arnd@kernel.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/atm/resources.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/atm/resources.c b/net/atm/resources.c
    index 53236986dfe09..3ad39ae971323 100644
    --- a/net/atm/resources.c
    +++ b/net/atm/resources.c
    @@ -403,6 +403,7 @@ int atm_dev_ioctl(unsigned int cmd, void __user *buf, int __user *sioc_len,
    return error;
    }

    +#ifdef CONFIG_PROC_FS
    void *atm_dev_seq_start(struct seq_file *seq, loff_t *pos)
    {
    mutex_lock(&atm_dev_mutex);
    @@ -418,3 +419,4 @@ void *atm_dev_seq_next(struct seq_file *seq, void *v, loff_t *pos)
    {
    return seq_list_next(v, &atm_devs, pos);
    }
    +#endif
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-05-25 22:39    [W:5.244 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site