Messages in this thread | | | Date | Thu, 25 May 2023 11:35:13 -0700 | From | Luis Chamberlain <> | Subject | Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection |
| |
On Thu, May 25, 2023 at 11:08:13AM -0700, Luis Chamberlain wrote: > + fsdevel please review,
> So with two other hunks added (2nd and 4th), this now matches parity with > my patch, not suggesting this is right, just demonstrating how this > could be resolved with this. We could also just have a helper which lets > the module code allow_write_access() at the end of its use of the fd > (failure to load or module is removed).
This even fixes the pathological case with stress-ng for finit_module:
./stress-ng --module 8192 --module-name xfs
(stress-ng assumes you have all dependencies already loaded and the module is not loaded, it uses finit_module() directly)
Luis
| |