lkml.org 
[lkml]   [2023]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v3 4/6] net: phy: microchip_t1s: fix reset complete status handling
    > +	/* Read STS2 register and check for the Reset Complete status to do the
    > + * init configuration. If the Reset Complete is not set, wait for 5us
    > + * and then read STS2 register again and check for Reset Complete status.
    > + * Still if it is failed then declare PHY reset error or else proceed
    > + * for the PHY initial register configuration.
    > + */
    > + err = phy_read_mmd(phydev, MDIO_MMD_VEND2, LAN867X_REG_STS2);
    > + if (err < 0)
    > + return err;
    > +
    > + if (!(err & LAN867x_RESET_COMPLETE_STS)) {
    > + udelay(5);
    > + err = phy_read_mmd(phydev, MDIO_MMD_VEND2, LAN867X_REG_STS2);
    > + if (err < 0)
    > + return err;
    > + if (!(err & LAN867x_RESET_COMPLETE_STS)) {
    > + phydev_err(phydev, "PHY reset failed\n");
    > + return -ENODEV;
    > + }
    > + }

    This comment explains exactly what the code does, which is also obvious
    from reading the code. A meaningful comment would be explaining why the
    state can change 5us later.

    \
     
     \ /
      Last update: 2023-05-25 22:39    [W:4.718 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site