Messages in this thread | | | From | Saurabh Singh Sengar <> | Subject | RE: [EXTERNAL] Re: [PATCH 1/2] x86/Kconfig: Allow CONFIG_X86_MPPARSE disable for OF platforms | Date | Wed, 24 May 2023 16:23:03 +0000 |
| |
> -----Original Message----- > From: Dave Hansen <dave.hansen@intel.com> > Sent: Tuesday, May 23, 2023 11:23 PM > To: Saurabh Sengar <ssengar@linux.microsoft.com>; tglx@linutronix.de; > mingo@redhat.com; bp@alien8.de; dave.hansen@linux.intel.com; > x86@kernel.org; hpa@zytor.com; KY Srinivasan <kys@microsoft.com>; > Haiyang Zhang <haiyangz@microsoft.com>; wei.liu@kernel.org; Dexuan Cui > <decui@microsoft.com>; Michael Kelley (LINUX) <mikelley@microsoft.com>; > linux-kernel@vger.kernel.org; linux-hyperv@vger.kernel.org > Cc: Saurabh Singh Sengar <ssengar@microsoft.com> > Subject: [EXTERNAL] Re: [PATCH 1/2] x86/Kconfig: Allow > CONFIG_X86_MPPARSE disable for OF platforms > > On 5/11/23 07:54, Saurabh Sengar wrote: > > X86_MPPARSE is only selectable when ACPI is enabled. However, on > > Devicetree platforms where ACPI is disabled, it is always enabled. > > Allow X86_MPPARSE to be selected by OF platforms as well. > > I'm finding this changelog really hard to read. > > In Kconfig, you can "select FOO". But in this changelog, it means something > different. I think "selectable" here means that there's a user prompt for the > option. > > Could you please rephrase this to be less confusing?
Thanks for your review. Currently, in the absence of ACPI, it is impossible to disable X86_MPPARSE. In the case of ACPI being enabled, one has the option to either enable or disable X86_MPARSE. My intention is to permit X86_MPPARSE=n for OF platforms where ACPI=n. To describe the capability of choosing any desired value for MPPARSE, I used the term 'selectable.' Perhaps 'configurable' would be a more appropriate word in this context? I can fix this and include it in V2.
> > This is also one of those patches where I wonder: Why do _you_ care about > this? Are you just trying to be nice? Is this intended as some kind of cleanup?
It solves an issue for Hyper-V VBS setup, please refer to the 2/2 of this patch series.
Regards, Saurabh
| |