Messages in this thread | | | From | Maxim Kiselev <> | Date | Wed, 24 May 2023 14:36:28 +0300 | Subject | Re: [RFC PATCH v1 0/4] Add support for Allwinner GPADC on D1/T113s/R329 SoCs |
| |
Hi Andre,
thanks for you comments
> This may sound kind of obvious, but wouldn't it be easier to model this > with one compatible string, and have the number of channels as a DT > property?
Yes, I completely agree that using separate config for each SoCs is looks overcomplicated because the only difference is the number of channels. I thought about a DT property with channels number but I didn't find another ADC driver with the same approach (except i2c ADC's with child nodes).
> Or, alternatively, using iio/multiplexer/io-channel-mux.yaml, since it's > only one ADC anyway? I'm sorry, I didn't quite understand what you're suggesting.
> And btw: it seems that the T507 (the H616 die with a different pinout) has > the same IP, with four channels: > http://dl.linux-sunxi.org/T507/
Oh, thanks for pointing that. I'll add it to the list in the next version.
| |