lkml.org 
[lkml]   [2023]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH v1 0/4] Add support for Allwinner GPADC on D1/T113s/R329 SoCs
    Hi Andre,

    thanks for you comments

    > This may sound kind of obvious, but wouldn't it be easier to model this
    > with one compatible string, and have the number of channels as a DT
    > property?

    Yes, I completely agree that using separate config for each SoCs is looks
    overcomplicated because the only difference is the number of channels.
    I thought about a DT property with channels number but I didn't find
    another ADC driver with the same approach (except i2c ADC's with child nodes).

    > Or, alternatively, using iio/multiplexer/io-channel-mux.yaml, since it's
    > only one ADC anyway?
    I'm sorry, I didn't quite understand what you're suggesting.

    > And btw: it seems that the T507 (the H616 die with a different pinout) has
    > the same IP, with four channels:
    > http://dl.linux-sunxi.org/T507/

    Oh, thanks for pointing that. I'll add it to the list in the next version.

    \
     
     \ /
      Last update: 2023-05-24 13:37    [W:3.236 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site