lkml.org 
[lkml]   [2023]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v6 2/5] spi: spi-imx: add support for SPI_MOSI_IDLE_LOW mode bit
    From
    On 24.05.23 11:19, Boerge Struempfel wrote:
    > By default, the spi-imx controller pulls the mosi line high, whenever it
    > is idle. This behaviour can be inverted per CS by setting the
    > corresponding DATA_CTL bit in the config register of the controller.
    >
    > Also, since the controller mode-bits have to be touched anyways, the
    > SPI_CPOL and SPI_CPHA are replaced by the combined SPI_MODE_X_MASK flag.
    >
    > Signed-off-by: Boerge Struempfel <boerge.struempfel@gmail.com>

    Thanks for working on this! We used a similar downstream patch for
    driving NeoPixels with i.MX. I'm happy to see a proper upstream solution.

    I also have this Python module [1] around for using spidev to drive the
    LEDs. It would be nice to see support for SPI_MOSI_IDLE_LOW in py-spidev
    [2] so we could use it there. Though the latter looks a bit like it is
    not properly maintained anymore.

    [1] https://github.com/fschrempf/py-neopixel-spidev
    [2] https://github.com/doceme/py-spidev

    Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

    \
     
     \ /
      Last update: 2023-05-24 11:47    [W:3.892 / U:1.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site