Messages in this thread | | | Date | Wed, 24 May 2023 17:36:58 +0800 | Subject | Re: [PATCH v2 1/2] soc: hisilicon: Support HCCS driver on Kunpeng SoC | From | "lihuisong (C)" <> |
| |
在 2023/5/23 21:41, Sudeep Holla 写道: > On Tue, May 23, 2023 at 07:57:42PM +0800, lihuisong (C) wrote: >> 在 2023/5/23 17:39, Sudeep Holla 写道: >>> On Mon, May 22, 2023 at 03:22:10PM +0800, Huisong Li wrote: >>>> The Huawei Cache-Coherent System (HCCS) is a bus protocol standard >>>> for ensuring cache coherent on HiSilicon SoC. The performance of >>>> the application may be affected if some hccs ports are in non-full >>>> lane status, have a large number of CRC errors and so on. >>>> >>>> This driver provides the query interface of the health status and >>>> port information of HCCS on Kunpeng SoC. >>>> >>>> Signed-off-by: Huisong Li <lihuisong@huawei.com> >>>> --- >>>> MAINTAINERS | 6 + >>>> drivers/soc/Kconfig | 1 + >>>> drivers/soc/Makefile | 1 + >>>> drivers/soc/hisilicon/Kconfig | 19 + >>>> drivers/soc/hisilicon/Makefile | 2 + >>>> drivers/soc/hisilicon/kunpeng_hccs.c | 1287 ++++++++++++++++++++++++++ >>>> drivers/soc/hisilicon/kunpeng_hccs.h | 196 ++++ >>>> 7 files changed, 1512 insertions(+) >>>> create mode 100644 drivers/soc/hisilicon/Kconfig >>>> create mode 100644 drivers/soc/hisilicon/Makefile >>>> create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.c >>>> create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.h >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index eddbc48c61e9..fe0e796e8445 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -9399,6 +9399,12 @@ S: Maintained >>>> W: http://www.hisilicon.com >>>> F: drivers/spi/spi-hisi-sfc-v3xx.c >>>> +HISILICON KUNPENG SOC HCCS DRIVER >>> s/HCCS/HCCS INFO or QUERY/ ? >> From the current features, what you suggest is suitable. >> But this driver will support to the setting feature. > Ah OK, I wasn't aware of that, in that case it is fine to keep it as is > and add comment about future feature expansions so that the name makes It's not suitable to add it in advance. > more sense them. I assumed it is more a query interface. Yes, most of them are query interfaces. > > I also assume the settings with just control performance and is fully > safe and stability of the system is taken care. Yes, it will has an impact on performance and power consumption, but not functionality. > > [...] > >>>> + >>>> +/* PCC defines */ >>>> +#define HCCS_PCC_SIGNATURE_MASK 0x50434300 >>>> +#define HCCS_PCC_STATUS_CMD_COMPLETE BIT(0) >>> I am not really sure if we keep duplicating this. I will try to cook up >>> a patch consolidating these. >> Yes, these info is better placed in a global header. >> Do I need to do this in this series? >> Or do not modify it, and then process all related code in your patch. > Fair enough, we can do that later. I don't want to block this for that reason. ok, thanks. will send v3 ASAP. >
| |