Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 24 May 2023 14:12:36 -0700 | Subject | Re: [v2 1/4] drm/panel: Support for Starry-himax83102-j02 TDDI MIPI-DSI panel |
| |
Hi,
On Wed, May 24, 2023 at 12:28 AM Cong Yang <yangcong5@huaqin.corp-partner.google.com> wrote: > > The Starry-himax83102-j02 is a 10.51" WUXGA TFT panel. which fits in nicely > with the existing panel-boe-tv101wum-nl6 driver. From the datasheet[1], MIPI > needs to keep the LP11 state before the lcm_reset pin is pulled high, so > increase lp11_before_reset flag. > > [1]: https://github.com/HimaxSoftware/Doc/tree/main/Himax_Chipset_Power_Sequence > > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> > --- > .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 100 ++++++++++++++++++ > 1 file changed, 100 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > index f5a6046f1d19..5c8ec263e11f 100644 > --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > @@ -76,6 +76,75 @@ struct panel_init_cmd { > .len = sizeof((char[]){__VA_ARGS__}), \ > .data = (char[]){__VA_ARGS__} } > > +static const struct panel_init_cmd starry_himax83102_j02_init_cmd[] = {
nit: Please have the order of the tables match the order they're referenced. That means this should come _after_ "starry_qfh032011_53g_init_cmd", not at the start of the tables.
-Doug
| |