lkml.org 
[lkml]   [2023]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/3] dt-bindings: thermal: tsens: Add ipq9574 compatible
On Wed, May 24, 2023 at 03:06:09PM +0530, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@quicinc.com>
>
> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> [v4]:
> Add description about IPQ9574 and remove unnecessary
> additions to the file
> [v3]:
> Fix dt_binding_check & dtbs_check errors (Used
> Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> as reference/example)
>
> Drop 'Acked-by: Rob Herring' as suggested in review
>
> [v2]:
> Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> for the tip to make qcom,ipq8074-tsens as fallback.

Thanks for re-sending. I'm going to "ignore" this patch & Krzysztof can
take a look at it next week.

Cheers,
Conor.

> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d1ec963..1a752e0 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -16,9 +16,14 @@ description: |
> The IP versions are named v0.1, v1 and v2 in the driver, where v0.1 captures
> everything before v1 when there was no versioning information.
>
> + Since IPQ9574 is similar to IPQ8074, mapping it to IPQ8074 without
> + introducing a new compatible.
> +
> properties:
> compatible:
> oneOf:
> + - const: qcom,ipq8074-tsens
> +
> - description: msm8960 TSENS based
> items:
> - enum:
> @@ -64,8 +69,10 @@ properties:
> - const: qcom,tsens-v2
>
> - description: v2 of TSENS with combined interrupt
> - enum:
> - - qcom,ipq8074-tsens
> + items:
> + - enum:
> + - qcom,ipq9574-tsens
> + - const: qcom,ipq8074-tsens
>
> reg:
> items:
> --
> 2.7.4
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-05-24 21:36    [W:0.094 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site