Messages in this thread Patch in this message | | | Date | Tue, 23 May 2023 15:38:16 +0900 | Subject | Re: linux-next: build warning after merge of the scsi-mkp tree | From | Damien Le Moal <> |
| |
On 5/23/23 12:38, Stephen Rothwell wrote: > Hi all, > > After merging the scsi-mkp tree, today's linux-next build (htmldocs) > produced this warning: > > drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control' > > Introduced by commit > > df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation") >
Martin,
This is missing:
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 69fc0d2c2123..c676b1e9b6c9 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct ata_queued_cmd *qc, /** * ata_mselect_control - Simulate MODE SELECT for control page * @qc: Storage for translated ATA taskfile + * @spg: sub-page of the control page * @buf: input buffer * @len: number of valid bytes in the input buffer * @fp: out parameter for the failed field on error Do you want me to send a fix patch or can you fold this in ?
-- Damien Le Moal Western Digital Research
| |