Messages in this thread | | | Date | Tue, 23 May 2023 08:28:16 +0200 | Subject | Re: Stable backport request: skbuff: Proactively round up to kmalloc bucket size | From | Vlastimil Babka <> |
| |
On 5/22/23 20:23, Daniel Díaz wrote: > Hello! > > Would the stable maintainers please consider backporting the following > commit to the 6.1? We are trying to build gki_defconfig (plus a few > extras) on Arm64 and test it under Qemu-arm64, but it fails to boot. > Bisection has pointed here.
You mean the bisection was done to find the first "good" commit between 6.1 and e.g. 6.3?
As others said, this commit wasn't expected to be a fix to a known bug. Maybe you found one that we didn't know of, or it might be accidentaly masking some other bug.
> We have verified that cherry-picking this patch on top of v6.1.29 > applies cleanly and allows the kernel to boot. > > commit 12d6c1d3a2ad0c199ec57c201cdc71e8e157a232 > Author: Kees Cook <keescook@chromium.org> > Date: Tue Oct 25 15:39:35 2022 -0700 > > skbuff: Proactively round up to kmalloc bucket size > > Instead of discovering the kmalloc bucket size _after_ allocation, round > up proactively so the allocation is explicitly made for the full size, > allowing the compiler to correctly reason about the resulting size of > the buffer through the existing __alloc_size() hint. > > This will allow for kernels built with CONFIG_UBSAN_BOUNDS or the > coming dynamic bounds checking under CONFIG_FORTIFY_SOURCE to gain > back the __alloc_size() hints that were temporarily reverted in commit > 93dd04ab0b2b ("slab: remove __alloc_size attribute from > __kmalloc_track_caller") > > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: netdev@vger.kernel.org > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: David Rientjes <rientjes@google.com> > Acked-by: Vlastimil Babka <vbabka@suse.cz> > Link: https://patchwork.kernel.org/project/netdevbpf/patch/20221021234713.you.031-kees@kernel.org/ > Signed-off-by: Kees Cook <keescook@chromium.org> > Link: https://lore.kernel.org/r/20221025223811.up.360-kees@kernel.org > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > > > Thanks and greetings! > > Daniel Díaz > daniel.diaz@linaro.org
| |