Messages in this thread | | | Date | Tue, 23 May 2023 16:22:29 +0200 | Subject | Re: [PATCH v2 1/7] ASoC: mediatek: mt8188: separate ADDA playback dai from capture dai | From | Alexandre Mergnat <> |
| |
On 23/05/2023 04:19, Trevor Wu wrote: > MT8188 will support SOF. In SOF, be_hw_params_fixup callback are used to
Can you write what is SOF please ? (Sound Open Firmware I guess ?)
> configure BE hardware parameters. However, playback and capture stream > share the same callback function in which it can't know the stream type. > > It's possible to require different paremters for playback and capture
paremters => parameters
Code looks good, after the commit messages fixes:
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
-- Regards, Alexandre
| |