Messages in this thread | | | Date | Tue, 23 May 2023 07:16:55 -0700 | Subject | Re: [PATCH 2/2] signal: move show_unhandled_signals sysctl to its own file | From | Dave Hansen <> |
| |
On 5/22/23 14:08, Luis Chamberlain wrote: > --- a/arch/x86/kernel/umip.c > +++ b/arch/x86/kernel/umip.c > @@ -12,6 +12,7 @@ > #include <asm/insn.h> > #include <asm/insn-eval.h> > #include <linux/ratelimit.h> > +#include <linux/signal.h>
Oh, so this is actually fixing a bug: umip.c uses 'show_unhandled_signals' but it doesn't explicitly include linux/signal.h where 'show_unhandled_signals' is declared.
It doesn't actually have anything to do with moving the show_unhandled_signals sysctl, right?
If that's the case, it would be nice to have this in its own patch.
| |