Messages in this thread | | | From | Zhu Yanjun <> | Date | Tue, 23 May 2023 12:29:33 +0800 | Subject | Re: [syzbot] [rdma?] INFO: trying to register non-static key in skb_dequeue (2) |
| |
On Tue, May 23, 2023 at 12:10 PM Guoqing Jiang <guoqing.jiang@linux.dev> wrote: > > > > On 5/23/23 12:02, Zhu Yanjun wrote: > > On Tue, May 23, 2023 at 11:47 AM Zhu Yanjun <zyjzyj2000@gmail.com> wrote: > >> On Tue, May 23, 2023 at 10:26 AM Guoqing Jiang <guoqing.jiang@linux.dev> wrote: > >>> > >>> > >>> On 5/23/23 10:13, syzbot wrote: > >>>> Hello, > >>>> > >>>> syzbot tried to test the proposed patch but the build/boot failed: > >>>> > >>>> failed to apply patch: > >>>> checking file drivers/infiniband/sw/rxe/rxe_qp.c > >>>> patch: **** unexpected end of file in patch > >> This is not the root cause. The fix is not good. > > This problem is about "INFO: trying to register non-static key. The > > code is fine but needs lockdep annotation, or maybe"
This warning is from "lock is not initialized". This is a use-before-initialized problem. The correct fix is to initialize the lock that is complained before it is used.
Zhu Yanjun > > Which is caused by "skb_queue_head_init(&qp->resp_pkts)" is not called > given rxe_qp_init_resp returns error, but the cleanup still trigger the > chain. > > rxe_qp_do_cleanup -> rxe_completer -> drain_resp_pkts -> > skb_dequeue(&qp->resp_pkts) > > But I might misunderstood it ... > > Thanks, > Guoqing
| |