Messages in this thread | | | Date | Tue, 23 May 2023 13:07:36 +0200 | Subject | Re: [PATCH v2 4/4] platform/x86/amd: pmc: Use pm_pr_dbg() for suspend related messages | From | Hans de Goede <> |
| |
Hi Mario,
On 5/22/23 22:00, Mario Limonciello wrote: > Using pm_pr_dbg() allows users to toggle `/sys/power/pm_debug_messages` > as a single knob to turn on messages that amd-pmc can emit to aid in > any s2idle debugging. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/platform/x86/amd/pmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c > index 427905714f79..1304cd6f13f6 100644 > --- a/drivers/platform/x86/amd/pmc.c > +++ b/drivers/platform/x86/amd/pmc.c > @@ -543,7 +543,7 @@ static int amd_pmc_idlemask_read(struct amd_pmc_dev *pdev, struct device *dev, > } > > if (dev) > - dev_dbg(pdev->dev, "SMU idlemask s0i3: 0x%x\n", val); > + pm_pr_dbg("SMU idlemask s0i3: 0x%x\n", val); > > if (s) > seq_printf(s, "SMU idlemask : 0x%x\n", val);
This does not compile, amd/pmc.c may be build as an amd-pmc.ko module and currently the pm_debug_messages_on flag used by pm_pr_dbg() is not exported to modules:
CC [M] drivers/platform/x86/amd/pmc.o LD [M] drivers/platform/x86/amd/amd-pmc.o MODPOST Module.symvers ERROR: modpost: "pm_debug_messages_on" [drivers/platform/x86/amd/amd-pmc.ko] undefined! make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 make: *** [Makefile:1978: modpost] Error 2
Regards,
Hans
| |