lkml.org 
[lkml]   [2023]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 1/7] ASoC: mediatek: mt8188: separate ADDA playback dai from capture dai
Date
On Tue, 2023-05-23 at 16:22 +0200, Alexandre Mergnat wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 23/05/2023 04:19, Trevor Wu wrote:
> > MT8188 will support SOF. In SOF, be_hw_params_fixup callback are
> > used to
>
> Can you write what is SOF please ? (Sound Open Firmware I guess ?)
>
> > configure BE hardware parameters. However, playback and capture
> > stream
> > share the same callback function in which it can't know the stream
> > type.
> >
> > It's possible to require different paremters for playback and
> > capture
>
> paremters => parameters
>
> Code looks good, after the commit messages fixes:
>
> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
>
> --
> Regards,
> Alexandre
>
Hi Alexandre,

Thank you for pointing out my mistake.
I will correct it in v3.

Thanks,
Trevor
\
 
 \ /
  Last update: 2023-05-24 04:10    [W:0.060 / U:2.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site