Messages in this thread | | | From | Wells Lu 呂芳騰 <> | Subject | RE: [PATCH] pinctrl:sunplus: Add check for kmalloc | Date | Tue, 23 May 2023 17:39:51 +0000 |
| |
> > Fix Smatch static checker warning: > > potential null dereference 'configs'. (kmalloc returns null) > > ... > > > configs = kmalloc(sizeof(*configs), GFP_KERNEL); > > + if (!configs) > > > + return -ENOMEM; > > "Fixing" by adding a memory leak is not probably a good approach.
Do you mean I need to free all memory which are allocated in this subroutine before return -ENOMEM?
> ... > > > configs = kmalloc(sizeof(*configs), GFP_KERNEL); > > + if (!configs) > > + return -ENOMEM; > > Ditto. > > ... > > It might be that I'm mistaken. In this case please add an explanation why in the commit > message. > > -- > With Best Regards, > Andy Shevchenko >
Best regards, Wells Lu
| |