lkml.org 
[lkml]   [2023]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 3/3] net: dsa: mv88e6xxx: add support for MV88E6071 switch
    On Tue, May 23, 2023 at 04:29:12PM +0200, Lukasz Majewski wrote:
    > A mv88e6250 family (i.e. "LinkStreet") switch with 5 internal PHYs,
    > 2 RMIIs and no PTP support.

    chip.h says:

    MV88E6XXX_FAMILY_6250, /* 6220 6250 */

    Please update this comment.

    I would also suggest you don't call the mv88e6250 family
    "LinkStreet". All Marvell SoHo switches are LinkStreet, all switches
    supported by the mv88e6xxx driver are "LinkStreet".

    With these changes:

    Reviewed-by: Andrew Lunn <andrew@lunn.ch>


    Andrew

    ---
    pw-bot: cr

    \
     
     \ /
      Last update: 2023-05-23 19:38    [W:3.063 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site