Messages in this thread | | | Date | Tue, 23 May 2023 10:31:44 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 1/2][next] scsi: lpfc: Replace one-element array with flexible-array member |
| |
On Mon, May 22, 2023 at 06:02:21PM -0400, Martin K. Petersen wrote: > > Gustavo, > > > One-element arrays are deprecated, and we are replacing them with flexible > > array members instead. So, replace one-element arrays with flexible-array > > members in a couple of structures, and refactor the rest of the code, > > accordingly. > > > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE > > routines on memcpy() and help us make progress towards globally > > enabling -fstrict-flex-arrays=3 [1]. > > > > This results in no differences in binary output. > > Applied to 6.5/scsi-staging, thanks!
Martin, I think this patch is not right -- can you drop this from staging for the moment?
-- Kees Cook
| |