lkml.org 
[lkml]   [2023]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 25/44] PCI/sysfs: Make I/O resource depend on HAS_IOPORT
    Date
    If legacy I/O spaces are not supported simply return an error when
    trying to access them via pci_resource_io(). This allows inb() and
    friends to become undefined when they are known at compile time to be
    non-functional in a later patch.

    Co-developed-by: Arnd Bergmann <arnd@kernel.org>
    Signed-off-by: Arnd Bergmann <arnd@kernel.org>
    Acked-by: Bjorn Helgaas <bhelgaas@google.com>
    Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
    ---
    drivers/pci/pci-sysfs.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
    index ab32a91f287b..d9eede2dbc0e 100644
    --- a/drivers/pci/pci-sysfs.c
    +++ b/drivers/pci/pci-sysfs.c
    @@ -1083,6 +1083,7 @@ static ssize_t pci_resource_io(struct file *filp, struct kobject *kobj,
    struct bin_attribute *attr, char *buf,
    loff_t off, size_t count, bool write)
    {
    +#ifdef CONFIG_HAS_IOPORT
    struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));
    int bar = (unsigned long)attr->private;
    unsigned long port = off;
    @@ -1116,6 +1117,9 @@ static ssize_t pci_resource_io(struct file *filp, struct kobject *kobj,
    return 4;
    }
    return -EINVAL;
    +#else
    + return -ENXIO;
    +#endif
    }

    static ssize_t pci_read_resource_io(struct file *filp, struct kobject *kobj,
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-05-22 12:54    [W:2.714 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site