lkml.org 
[lkml]   [2023]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net 3/3] net: phy: mscc: enable VSC8501/2 RGMII RX clock
On Mon, May 22, 2023 at 12:49:44PM +0300, Vladimir Oltean wrote:
> Well, to be clear, I was suggesting:
>
> /* Set the RGMII RX and TX clock skews individually, according to the PHY
> * interface type, to:
> * * 0.2 ns (their default, and lowest, hardware value) if delays should
> * not be enabled
> * * 2.0 ns (which causes the data to be sampled at exactly half way between
> * clock transitions at 1000 Mbps) if delays should be enabled
> */
> static int vsc85xx_rgmii_set_skews(struct phy_device *phydev, u32 rgmii_cntl,
> u16 rgmii_rx_delay_mask,
> u16 rgmii_tx_delay_mask)
> {
> u16 rgmii_rx_delay_pos = ffs(rgmii_rx_delay_mask) - 1;
> u16 rgmii_tx_delay_pos = ffs(rgmii_tx_delay_mask) - 1;
> u16 mask = rgmii_rx_delay_mask | rgmii_tx_delay_mask;
> u16 reg_val = 0;
> int rc;

Or rather:

u16 mask = 0;

if (phy_interface_is_rgmii(phydev))
mask |= rgmii_rx_delay_mask | rgmii_tx_delay_mask;

if (rgmii_cntl == VSC8502_RGMII_CNTL)
mask |= VSC8502_RGMII_RX_CLK_DISABLE;

>
> /* For traffic to pass, the VSC8502 family needs the RX_CLK disable bit
> * to be unset for all PHY modes, so do that as part of the paged
> * register modification.
> */
> if (rgmii_cntl == VSC8502_RGMII_CNTL)
> mask |= VSC8502_RGMII_RX_CLK_DISABLE;
>
> mutex_lock(&phydev->lock);
>
> if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID ||
> phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
> reg_val |= RGMII_CLK_DELAY_2_0_NS << rgmii_rx_delay_pos;
> if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID ||
> phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
> reg_val |= RGMII_CLK_DELAY_2_0_NS << rgmii_tx_delay_pos;
>
> rc = phy_modify_paged(phydev, MSCC_PHY_PAGE_EXTENDED_2,
> rgmii_cntl, mask, reg_val);
>
> mutex_unlock(&phydev->lock);
>
> return rc;
> }

\
 
 \ /
  Last update: 2023-05-22 11:55    [W:0.072 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site