Messages in this thread | | | Date | Mon, 22 May 2023 08:14:26 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v4 2/2] leds: add aw20xx driver |
| |
On Thu, 18 May 2023, Andy Shevchenko wrote:
> On Wed, May 17, 2023 at 10:52 PM Martin Kurbanov > <mmkurbanov@sberdevices.ru> wrote: > > > > This commit adds support for AWINIC AW20036/AW20054/AW20072 LED driver. > > This driver supports following AW200XX features: > > - Individual 64-level DIM currents > > With or without below > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > ... > > > +static int aw200xx_probe_dt(struct device *dev, struct aw200xx *chip) > > _dt is not fully correct suffix, it's now firmware properties, so perhaps _fw? > > ... > > I would do > > i = 0; > > here and drop the assignment in the definition block to be more robust
"here" where?
You've removed all context.
> against sudden reuse of i in between. > > > + device_for_each_child_node(dev, child) { > > > + i++; > > + } > > -- > With Best Regards, > Andy Shevchenko
-- Lee Jones [李琼斯]
| |