Messages in this thread | | | Date | Mon, 22 May 2023 11:10:48 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH] PCI: dwc: keystone: Free IRQ in `ks_pcie_remove` and the error handling section of `ks_pcie_probe` |
| |
On Mon, May 22, 2023 at 02:07:10PM +0800, 曾祥翼 wrote: > On 17/5/2023 03:49, Bjorn Helgaas wrote: > > On Tue, May 16, 2023 at 01:16:59PM +0800, Xiangyi Zeng wrote: > > ...
> > > Fixes: 0790eb175ee0 ("PCI: keystone: Cleanup error_irq configuration") > > > Signed-off-by: Xiangyi Zeng <xyzeng@stu.xidian.edu.cn> > > > Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> > > > > It's best if the Reviewed-by tag is not added until Dongliang sends > > email with that tag directly to the mailing list. Internal reviews > > before posting to the mailing list aren't worth much. > > In our internal review process, only the patch with the Reviewed-by > tag can be submitted to the mailing list. You can check this in our > google group. > https://groups.google.com/g/hust-os-kernel-patches/c/bt397rzVL24/m/l52XYbG4AgAJ > We will consider omitting this tag when sending to the kernel mailing > list in the future.
It's great that Dongliang has already reviewed it; I'm not suggesting you omit any of that internal review. My point is that it's best if Dongliang's email review appears on linux-pci in addition to whatever internal email list you use. The hust-os-kernel-patches Google Group is not archived and searchable the same way linux-pci@vger.kernel.org is on https://lore.kernel.org/linux-pci/.
Bjorn
| |