lkml.org 
[lkml]   [2023]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net 3/3] net: phy: mscc: enable VSC8501/2 RGMII RX clock
On Mon, May 22, 2023 at 05:22:21PM +0200, David Epping wrote:
> > > Also we don't want to enable for
> > > all PHY types, and the differentiation is already available at the
> > > caller. I would thus opt for a separate function and fewer conditional
> > > statements.
> >
> > I don't understand this. We don't? For what PHY types don't we want to
> > enable the RX_CLK?
>
> I meant all PHYs using vsc85xx_rgmii_set_skews() via vsc8584_config_init().

Aha. By "PHY types" I thought you mean "PHY interface types" like RGMII/GMII/MII,
not PHY device models.

> As you pointed out they don't have a clear definition of what bit 11 means
> for them.

And I wasn't suggesting to make bit 11 part of the modified "mask" for them.

> But we can easily differentiate using the condition you suggested.
> I'll do that for the new patch version.

Sounds good, thanks.

\
 
 \ /
  Last update: 2023-05-22 18:48    [W:0.058 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site