| Date | Sat, 20 May 2023 11:41:27 +0200 | From | Christian Brauner <> | Subject | Re: [PATCH v21 08/30] splice: Make splice from a DAX file use copy_splice_read() |
| |
On Sat, May 20, 2023 at 01:00:27AM +0100, David Howells wrote: > Make a read splice from a DAX file go directly to copy_splice_read() to do > the reading as filemap_splice_read() is unlikely to find any pagecache to > splice. > > I think this affects only erofs, Ext2, Ext4, fuse and XFS. > > Signed-off-by: David Howells <dhowells@redhat.com> > cc: Christoph Hellwig <hch@lst.de> > cc: Al Viro <viro@zeniv.linux.org.uk> > cc: Jens Axboe <axboe@kernel.dk> > cc: linux-erofs@lists.ozlabs.org > cc: linux-ext4@vger.kernel.org > cc: linux-xfs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org > ---
Fwiw, O_DIRECT and DAX could've just been folded into one patch imho. Reviewed-by: Christian Brauner <brauner@kernel.org>
|