lkml.org 
[lkml]   [2023]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc
From

On 5/19/23 2:21 PM, Komal Bajaj wrote:
> Add sdhci node for emmc in qdu1000-idp.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> index 9e9fd4b8023e..b2526e991548 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> @@ -451,3 +451,14 @@
> &uart7 {
> status = "okay";
> };
> +
> +&sdhc_1 {
> + status = "okay";
> +
> + pinctrl-0 = <&sdc1_on_state>;
> + pinctrl-1 = <&sdc1_off_state>;
> + pinctrl-names = "default", "sleep";
> +
> + vmmc-supply = <&vreg_l10a_2p95>;
> + vqmmc-supply = <&vreg_l7a_1p8>;
> +};

Again, please follow alphabetical order for adding new node entries.

Also, we have been placing 'status = .. ' entry at the end for new .dts
(or .dts entry), but if that is the format used across this board dts
I am ok with the same.

Thanks,
Bhupesh

\
 
 \ /
  Last update: 2023-05-19 12:13    [W:0.569 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site