Messages in this thread | | | Date | Thu, 18 May 2023 23:16:34 +0530 | Subject | Re: [PATCH 07/11] mailbox: qcom-apcs-ipc: Add IPQ5018 APCS IPC support | From | Manikanta Mylavarapu <> |
| |
On 3/7/2023 8:50 PM, Krzysztof Kozlowski wrote: > On 07/03/2023 05:41, Manikanta Mylavarapu wrote: >> Enable IPQ5018 APCS IPC support by adding the compatible. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> index 6bbf87c6d60b..0b873c76fd7e 100644 >> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> @@ -141,6 +141,7 @@ static int qcom_apcs_ipc_remove(struct platform_device *pdev) >> >> /* .data is the offset of the ipc register within the global block */ >> static const struct of_device_id qcom_apcs_ipc_of_match[] = { >> + { .compatible = "qcom,ipq5018-apcs-apps-global", .data = &ipq6018_apcs_data }, > > Why do you need new entry with same driver data? > > Best regards, > Krzysztof > Yeah it's not required. Since i already updated bindings, i will drop this patch.
Thanks & Regards, Manikanta.
| |