lkml.org 
[lkml]   [2023]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 4/4] drm/msm/dpu: drop DSPP_MSM8998_MASK from hw catalog
    From


    On 5/18/2023 2:36 PM, Marijn Suijten wrote:
    > On 2023-05-19 00:26:33, Dmitry Baryshkov wrote:
    >> On 18/05/2023 22:41, Marijn Suijten wrote:
    >>> On 2023-04-28 15:36:46, Abhinav Kumar wrote:
    >>>> Since GC and IGC masks have now been dropped DSPP_MSM8998_MASK
    >>>> is same as DSPP_SC7180_MASK. Since DSPP_SC7180_MASK is used more
    >>>
    >>> is *the* same
    >>
    >> And, I think, a comma is missing before DSPP_MSM8998_MASK.
    >
    > Possible, but not needed I think; both would work.
    >
    >> Note: since the English language is not native for most of the
    >> developers, I usually don't nitpick on these issues provided we can
    >> understand the message without too much trouble (and the mistake doesn't
    >> stand out aloud, begging for it to be fixed).
    >

    I also dont nitpick on these.

    > I hope you don't mind me pointing them out when they make the reader go
    > "huh, a word is missing here", breaking my sentence-parser.
    >
    > - Marijn

    Sure, but I dont expect another version to be sent if that was the only
    issue.

    >
    >> I will fix missing articles when applying, if I don't forget.
    >
    > <snip>

    \
     
     \ /
      Last update: 2023-05-19 00:19    [W:4.028 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site