lkml.org 
[lkml]   [2023]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock
From
On 16/05/2023 11:52, Krzysztof Kozlowski wrote:
> The initial SM8250 GCC driver added in commit 3e5770921a88 ("clk: qcom:
> gcc: Add global clock controller driver for SM8250") already consumed it
> on the clock. This fixes warnings like:
>
> sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long
>
> Fixes: 98394efb48f5 ("dt-bindings: clock: Add SM8250 GCC clock bindings")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes in v2:
> 1. Re-word commit msg and fixes tag (Konrad)
> 2. Add tags
> ---
> Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> index b752542ee20c..ead6665b9a45 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> @@ -23,11 +23,13 @@ properties:
> clocks:
> items:
> - description: Board XO source
> + - description: Board active XO source
> - description: Sleep clock source
>
> clock-names:
> items:
> - const: bi_tcxo
> + - const: bi_tcxo_ao
> - const: sleep_clk
>
> required:
> @@ -47,8 +49,9 @@ examples:
> compatible = "qcom,gcc-sm8250";
> reg = <0x00100000 0x1f0000>;
> clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&rpmhcc RPMH_CXO_CLK_A>,
> <&sleep_clk>;
> - clock-names = "bi_tcxo", "sleep_clk";
> + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk";
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;

LGTM

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

\
 
 \ /
  Last update: 2023-05-16 15:42    [W:0.057 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site