Messages in this thread |  | | From | Stanley Chu <> | | Date | Wed, 17 May 2023 11:15:34 +0800 | | Subject | Re: [PATCH v5 5/7] ufs: mcq: Added ufshcd_mcq_abort() |
| |
Hi Bao D.
> @@ -7562,6 +7561,12 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) > if (is_mcq_enabled(hba)) > goto release;
Should we remove the above lines because the code below will not be executed in the MCQ path?
> > + if (is_mcq_enabled(hba)) { > + /* MCQ mode. Branch off to handle abort for mcq mode */ > + err = ufshcd_mcq_abort(cmd); > + goto release; > + } > + > /* Skip task abort in case previous aborts failed and report failure */ > if (lrbp->req_abort_skip) { > dev_err(hba->dev, "%s: skipping abort\n", __func__); > -- > 2.7.4 >
|  |