lkml.org 
[lkml]   [2023]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 4/7] net: lan966x: Add support for offloading dscp table
From
Date
On Sun, 2023-05-14 at 22:10 +0200, Horatiu Vultur wrote:
> @@ -117,12 +164,16 @@ static int lan966x_dcb_ieee_setapp(struct net_device *dev, struct dcb_app *app)
> if (prio) {
> app_itr = *app;
> app_itr .priority = prio;
> - dcb_ieee_delapp(dev, &app_itr);
> + lan966x_dcb_ieee_delapp(dev, &app_itr);
> }
>
> - err = dcb_ieee_setapp(dev, app);
> + if (app->selector == IEEE_8021QAZ_APP_SEL_DSCP)
> + err = lan966x_dcb_ieee_dscp_setdel(dev, app, dcb_ieee_setapp);
> + else
> + err = dcb_ieee_setapp(dev, app);
> +
> if (err)
> - goto out;
> + return err;

As Piotr suggested, please drop the out: label altogether, replacing
even the other 'goto out;' statement with a plain return. Additionally
you can replace the final:

return err;

in this function with:

return 0;

Thanks,

Paolo

\
 
 \ /
  Last update: 2023-05-16 09:18    [W:0.237 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site