Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 16 May 2023 13:46:23 -0700 | Subject | Re: [PATCH] procfs: consolidate arch_report_meminfo declaration | From | Dave Hansen <> |
| |
On 5/16/23 12:57, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The arch_report_meminfo() function is provided by four architectures, > with a __weak fallback in procfs itself. On architectures that don't > have a custom version, the __weak version causes a warning because > of the missing prototype. > > Remove the architecture specific prototypes and instead add one > in linux/proc_fs.h. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/parisc/include/asm/pgtable.h | 3 --- > arch/powerpc/include/asm/pgtable.h | 3 --- > arch/s390/include/asm/pgtable.h | 3 --- > arch/s390/mm/pageattr.c | 1 + > arch/x86/include/asm/pgtable.h | 1 + > arch/x86/include/asm/pgtable_types.h | 3 ---
Looks sane. Thanks Arnd!
Acked-by: Dave Hansen <dave.hansen@linux.intel.com> # for arch/x86
| ![\](/images/icornerr.gif) |