Messages in this thread | | | Date | Mon, 15 May 2023 12:24:25 +0200 | From | Piotr Raczynski <> | Subject | Re: [PATCH net-next 2/7] net: lan966x: Add support for offloading pcp table |
| |
On Mon, May 15, 2023 at 12:16:49PM +0200, Piotr Raczynski wrote:
[...]
> > +static int lan966x_dcb_ieee_setapp(struct net_device *dev, struct dcb_app *app) > > +{ > > + struct dcb_app app_itr; > > + int err; > > + u8 prio; > > + > > + err = lan966x_dcb_app_validate(dev, app); > > + if (err) > > + goto out; > > + > > + /* Delete current mapping, if it exists */ > > + prio = dcb_getapp(dev, app); > > + if (prio) { > > + app_itr = *app; > > + app_itr .priority = prio; > Compiles OK, still looks little weird :). >
Other than that, looks OK. Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
[...]
| |