Messages in this thread | | | Date | Sun, 14 May 2023 22:09:50 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [RFC PATCH v3] can: virtio: Initial virtio CAN driver. |
| |
On 12.05.2023 19:39:40, Harald Mommer wrote: > > > diff --git a/drivers/net/can/Makefile b/drivers/net/can/Makefile > > > index ff8f76295d13..19314adaff59 100644 > > > --- a/drivers/net/can/Makefile > > > +++ b/drivers/net/can/Makefile > > > @@ -17,8 +17,8 @@ obj-$(CONFIG_CAN_AT91) += at91_can.o > > > obj-$(CONFIG_CAN_BXCAN) += bxcan.o > > > obj-$(CONFIG_CAN_CAN327) += can327.o > > > obj-$(CONFIG_CAN_CC770) += cc770/ > > > -obj-$(CONFIG_CAN_C_CAN) += c_can/ > > > obj-$(CONFIG_CAN_CTUCANFD) += ctucanfd/ > > > +obj-$(CONFIG_CAN_C_CAN) += c_can/ > > This reordering is unrelated to this patch goal. Please send it as a > > separate patch. > > @Marc Kleine-Budde: We got this reordering change from you.
That reordering was not intended.
> How to proceed?
Remove that change and sorry for the confusion.
> We can split this in 2 commits, reordering and on top adding virtio CAN. No > issue, a question of minutes and done. Fine. But here the word "patch" was > used, not the word "commit".
I think in first approximation patches and commits can be/are used interchangeably :) (One thought process might be: If you make it a separate commit and send it here, it's no longer in git and thus just a patch, no longer a commit.)
> Sending a separate patch to somewhere? Maybe > Mikhail does this fight to get this in (unlikely), I personally would prefer > to run away. Or we don't reorder at all, wrong ordering remains and we will > not make only you unhappy.
regards, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | [unhandled content-type:application/pgp-signature] | |