lkml.org 
[lkml]   [2023]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8: fix USB 3.0 Gadget Failure in QM & QXPB0 at super speed
Date

>
> > ---
> > arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > index b32c2e199c160..030c273c8be40 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > @@ -171,6 +171,7 @@ usbotg3_cdns3: usb@5b120000 {
> > interrupt-names = "host", "peripheral", "otg", "wakeup";
> > phys = <&usb3_phy>;
> > phy-names = "cdns3,usb3-phy";
> > + cdns,on-chip-buff-size = /bits/ 16 <18>;
>
> The property is defined as uint32 in the bindings. Not sure why we
> need to enforce 16-bits here.

Driver code use 16bit, if use 32bit here, it will be zero.
I have not checked bindings doc. Next version will fix binding doc.

Frank

>
> Shawn
>
> > status = "disabled";
> > };
> > };
> > --
> > 2.34.1
> >

\
 
 \ /
  Last update: 2023-05-13 06:25    [W:0.108 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site