Messages in this thread | | | Date | Fri, 12 May 2023 14:52:25 +0100 | From | Daniel Thompson <> | Subject | Re: [PATCH v8 08/10] kgdb: Provide a stub kgdb_nmicallback() if !CONFIG_KGDB |
| |
On Thu, May 11, 2023 at 07:34:30AM -0700, Doug Anderson wrote: > Hi, > > On Wed, Apr 19, 2023 at 3:57 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > To save architectures from needing to wrap the call in #ifdefs, add a > > stub no-op version of kgdb_nmicallback(), which returns 1 if it didn't > > handle anything. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Changes in v8: > > - "Provide a stub kgdb_nmicallback() if !CONFIG_KGDB" new for v8 > > > > include/linux/kgdb.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h > > index 87713bd390f3..9ce628ee47cc 100644 > > --- a/include/linux/kgdb.h > > +++ b/include/linux/kgdb.h > > @@ -377,5 +377,6 @@ extern void kgdb_free_init_mem(void); > > #define dbg_late_init() > > static inline void kgdb_panic(const char *msg) {} > > static inline void kgdb_free_init_mem(void) { } > > +static int kgdb_nmicallback(int cpu, void *regs) { return 1; } > > FWIW: I just realized that the above needs an "inline" to make the > compiler not complain. I'm still hoping for more feedback on the > series, but I'll plan to fix that in the next spin.
On the next spin feel free to add: Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
| |