Messages in this thread | | | Date | Thu, 11 May 2023 16:13:06 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 1/4] cxl/pci: Allocate irq vectors earlier in pci probe |
| |
On Fri, 21 Apr 2023 21:09:25 -0600 Vishal Verma <vishal.l.verma@intel.com> wrote:
> From: Davidlohr Bueso <dave@stgolabs.net> > > Move the cxl_alloc_irq_vectors() call further up in the probing > in order to allow for mailbox interrupt usage. No change in > semantics. > > Signed-off-by: Davidlohr Bueso <dave@stgolabs.net> > Link: https://lore.kernel.org/r/20230421092321.12741-2-dave@stgolabs.net > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
If it merges with this set to make life easier for picking it up I'll repeat this here.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> --- > drivers/cxl/pci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c > index 60b23624d167..39b829a29f6c 100644 > --- a/drivers/cxl/pci.c > +++ b/drivers/cxl/pci.c > @@ -757,6 +757,10 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > if (rc) > dev_dbg(&pdev->dev, "Failed to map RAS capability.\n"); > > + rc = cxl_alloc_irq_vectors(pdev); > + if (rc) > + return rc; > + > rc = cxl_pci_setup_mailbox(cxlds); > if (rc) > return rc; > @@ -777,10 +781,6 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > if (rc) > return rc; > > - rc = cxl_alloc_irq_vectors(pdev); > - if (rc) > - return rc; > - > cxlmd = devm_cxl_add_memdev(cxlds); > if (IS_ERR(cxlmd)) > return PTR_ERR(cxlmd); >
| |