lkml.org 
[lkml]   [2023]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 4/6] KVM: x86: Introduce untag_addr() in kvm_x86_ops
On Thu, May 11, 2023 at 05:18:31PM +0800, Binbin Wu wrote:
>> > + if (sign_ext_bit > 0)
>> > + *la = (sign_extend64(*la, sign_ext_bit) & ~BIT_ULL(63)) |
>> > + (*la & BIT_ULL(63));
>> nit: curly braces are needed.
>Even if it's only one statement (although splited to two lines), curly braces
>are needed?

I was under the impression somehow -- braces are needed if the statement
is split into two lines. But Sean said [1] curly braces are not needed
in this case. Thus, please disregard my comment.

[1]: https://lore.kernel.org/all/Y9B9Ey1hK9A7NDVb@google.com/

\
 
 \ /
  Last update: 2023-05-11 12:39    [W:0.074 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site