lkml.org 
[lkml]   [2023]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] accel/qaic: silence some uninitialized variable warnings
From
On 5/3/2023 4:41 AM, Dan Carpenter wrote:
> Smatch complains that these are not initialized if get_cntl_version()
> fails but we still print them in the debug message. Not the end of
> the world, but true enough. Let's just initialize them to a dummy value
> to make the checker happy.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Thanks for the cleanup.

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

Could use a fixes tag, and also I'd prefer to maintain the style of
sorting the variable declaration lines by line length. Given the minor
nature of these nits, I plan to address them.

\
 
 \ /
  Last update: 2023-05-10 16:58    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog