Messages in this thread | | | Date | Sun, 9 Apr 2023 20:10:01 +0300 | Subject | Re: [PATCH v2 3/3] venus: fix EOS handling in decoder stop command | From | Dmitry Baryshkov <> |
| |
On 07/04/2023 09:25, Dikshita Agarwal wrote: > Use firmware version based check to assign correct > device address for EOS buffer to fix the EOS handling > with different firmware version. > > Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com> > Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> > Signed-off-by: Viswanath Boma <quic_vboma@quicinc.com>
Order of sign-offs is incorrect. The SoB of the sender should be the last one.
> Tested-by: Nathan Hebert <nhebert@chromium.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/media/platform/qcom/venus/vdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index f0394b9..c59b34f 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -545,7 +545,7 @@ vdec_decoder_cmd(struct file *file, void *fh, struct v4l2_decoder_cmd *cmd) > > fdata.buffer_type = HFI_BUFFER_INPUT; > fdata.flags |= HFI_BUFFERFLAG_EOS; > - if (IS_V6(inst->core)) > + if (IS_V6(inst->core) && is_fw_rev_or_older(inst->core, 1, 0, 87)) > fdata.device_addr = 0; > else > fdata.device_addr = 0xdeadb000;
-- With best wishes Dmitry
| |