Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 7 Apr 2023 12:53:47 -0700 | Subject | Re: [PATCH 12/14] arm64: dts: qcom: sc7180: Fix trogdor qspi pin config |
| |
Hi,
On Fri, Apr 7, 2023 at 11:11 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 23/03/2023 18:30, Douglas Anderson wrote: > > In commit 7ec3e67307f8 ("arm64: dts: qcom: sc7180-trogdor: add initial > > trogdor and lazor dt") we specified the pull settings on the boot SPI > > (the qspi) data lines as pullups to "park" the lines. This seemed like > > the right thing to do, but I never really probed the lines to confirm. > > > > > > &qup_i2c2_default { > > @@ -1336,6 +1340,22 @@ p_sensor_int_l: p-sensor-int-l-state { > > bias-disable; > > }; > > > > + qspi_sleep: qspi-sleep-state { > > + pins = "gpio63", "gpio64", "gpio65", "gpio68"; > > + > > + /* > > + * When we're not actively transferring we want pins as GPIOs > > + * with output disabled so that the quad SPI IP block stops > > + * driving them. We rely on the normal pulls configured in > > + * the active state and don't redefine them here. Also note > > + * that we don't need the reverse (output-enable) in the > > + * normal mode since the "output-enable" only matters for > > + * GPIO function. > > + */ > > + function = "gpio"; > > + output-disable; > > Doug, > > I acked some of your patches, but I assumed you tested all this. It > turns out you never run dtbs_check on the patches you sent.
I'm fairly certain that I ran dtbs_check and confirmed that no new errors were introduced on the device tree files that this patch series cleaned up. Did I miss one? I did not try to go through and fix all examples of people using "input-enable" across all Qualcomm device trees, though. Those old device trees still work even if they're using the now-deprecated bindings. When deprecating something my understanding is that it's not required to go back and immediately transition all old device tree files.
If having the "input-enable: false" in the bindings is causing huge problems we could do a blank search-and-replace to rename it to "output-disable", at least for places under "tlmm". Even if there are cases where it's superfluous it would at least make the bindings validate.
-Doug
| |