Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 7 Apr 2023 09:22:55 -0700 | Subject | Re: [PATCH v5 1/4] arm64: dts: qcom: sc7180: Don't enable lpass clocks by default |
| |
Hi,
On Fri, Apr 7, 2023 at 8:14 AM Nikita Travkin <nikita@trvn.ru> wrote: > > lpass clocks are usually blocked from HLOS by the firmware and > instead are managed by the ADSP. Mark them as reserved and explicitly > enable in the CrOS boards that have special, cooperative firmware. > > Signed-off-by: Nikita Travkin <nikita@trvn.ru> > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > v5: minor style changes (Konrad) > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++ > 2 files changed, 12 insertions(+)
I probably would have put a note in the commit message about why you chose not to enable these for IDP (AKA summarize the results of the conversation [1] in your v3 post). IMO not worth spinning a v6 just for this, though.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
[1] https://lore.kernel.org/r/3557aa94-6a83-d054-a9d9-81751165eb8a@linaro.org
| |