lkml.org 
[lkml]   [2023]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 08/20] staging: media: tegra-video: move private struct declaration to C file
    Date
    struct tegra_vi_graph_entity is an internal implementation detail of the VI
    module. Move its declaration from vi.h to vi.c.

    Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
    Reviewed-by: Dmitry Osipenko <digetx@gmail.com>

    ---

    No changes in v5

    Changed in v4:
    - Added review tags

    No changes in v3
    No changes in v2
    ---
    drivers/staging/media/tegra-video/vi.c | 13 +++++++++++++
    drivers/staging/media/tegra-video/vi.h | 13 -------------
    2 files changed, 13 insertions(+), 13 deletions(-)

    diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c
    index ce4ff4cbf587..db98d06351b4 100644
    --- a/drivers/staging/media/tegra-video/vi.c
    +++ b/drivers/staging/media/tegra-video/vi.c
    @@ -32,6 +32,19 @@

    #define MAX_CID_CONTROLS 1

    +/**
    + * struct tegra_vi_graph_entity - Entity in the video graph
    + *
    + * @asd: subdev asynchronous registration information
    + * @entity: media entity from the corresponding V4L2 subdev
    + * @subdev: V4L2 subdev
    + */
    +struct tegra_vi_graph_entity {
    + struct v4l2_async_subdev asd;
    + struct media_entity *entity;
    + struct v4l2_subdev *subdev;
    +};
    +
    static const struct tegra_video_format tegra_default_format = {
    .img_dt = TEGRA_IMAGE_DT_RAW10,
    .bit_width = 10,
    diff --git a/drivers/staging/media/tegra-video/vi.h b/drivers/staging/media/tegra-video/vi.h
    index 5396bf53ab75..9959cbe02ca0 100644
    --- a/drivers/staging/media/tegra-video/vi.h
    +++ b/drivers/staging/media/tegra-video/vi.h
    @@ -98,19 +98,6 @@ struct tegra_vi {
    struct list_head vi_chans;
    };

    -/**
    - * struct tegra_vi_graph_entity - Entity in the video graph
    - *
    - * @asd: subdev asynchronous registration information
    - * @entity: media entity from the corresponding V4L2 subdev
    - * @subdev: V4L2 subdev
    - */
    -struct tegra_vi_graph_entity {
    - struct v4l2_async_subdev asd;
    - struct media_entity *entity;
    - struct v4l2_subdev *subdev;
    -};
    -
    /**
    * struct tegra_vi_channel - Tegra video channel
    *
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-04-07 15:42    [W:4.294 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site