Messages in this thread | | | Date | Thu, 6 Apr 2023 15:17:15 +0300 | Subject | Re: [PATCH 2/2] leds: bd2606mvv: Driver for the Rohm 6 Channel i2c LED driver | From | Matti Vaittinen <> |
| |
On 4/6/23 14:43, Andreas Kemnade wrote: > Hi Matti, > > thanks for the review: > > On Thu, 6 Apr 2023 11:57:15 +0300 > Matti Vaittinen <mazziesaccount@gmail.com> wrote: > >>> + priv->regmap = devm_regmap_init_i2c(client, &bd2606mvv_regmap); >>> + if (IS_ERR(priv->regmap)) { >>> + err = PTR_ERR(priv->regmap); >>> + dev_err(dev, "Failed to allocate register map: %d\n", err); >>> + return err; >>> + } >>> + >>> + i2c_set_clientdata(client, priv); >>> + >> >> The IC seems to have an enable pin. I think you might add the >> enable-gpio in dt-bindings and try to (optionally) get and enable it here. > > It has an enable pin. I would prefer to just have the binding as complete as > possible and have it added later in the driver by someone needing it > since I cannot test that.
Fair enough. Thanks for working with this!
Yours, -- Matti
-- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
| |