lkml.org 
[lkml]   [2023]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Litmus test names
On Thu, Apr 06, 2023 at 05:36:13PM -0400, Alan Stern wrote:
> Paul:
>
> I just saw that two of the files in tools/memory-model/litmus-tests have
> almost identical names:
>
> Z6.0+pooncelock+pooncelock+pombonce.litmus
> Z6.0+pooncelock+poonceLock+pombonce.litmus
>
> They differ only by a lower-case 'l' vs. a capital 'L'. It's not at all
> easy to see, and won't play well in case-insensitive filesystems.
>
> Should one of them be renamed?

Quite possibly!

The "L" denotes smp_mb__after_spinlock(). The only code difference
between these is that Z6.0+pooncelock+poonceLock+pombonce.litmus has
smp_mb__after_spinlock() and Z6.0+pooncelock+pooncelock+pombonce.litmus
does not.

Suggestions for a better name? We could capitalize all the letters
in LOCK, I suppose...

Thanx, Paul

\
 
 \ /
  Last update: 2023-04-07 00:35    [W:0.082 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site