Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: revert bab65e48cb064 PCI/MSI Sanitize MSI-X checks | Date | Thu, 06 Apr 2023 23:06:53 +0200 |
| |
On Thu, Apr 06 2023 at 12:35, Linus Torvalds wrote: >> Previously it returned 8. > > Does just moving the pci_msix_validate_entries() down to below the > hwsize update code fix it? > > IOW, something like this attached patch? > > ENTIRELY UNTESTED! This may be seriously broken for some reason, but > it does seem like the current code makes no sense (that "Keep the IRQ > virtual hackery working" comment seems to not possibly be true since > the MSIX nvec has effectively been checked against hwsize by the > pci_msix_validate_entries() code before).
Yes, that works too. But I rather remove the hwsize check from the validation function as I explained in my earlier reply to Bjorn in that thread.
Thanks,
tglx
| |