Messages in this thread | | | Date | Mon, 3 Apr 2023 20:08:19 +0300 | Subject | Re: [PATCH net-next v2 00/14] net: dsa: add support for MT7988 | From | Arınç ÜNAL <> |
| |
On 3.04.2023 04:16, Daniel Golle wrote: > The MediaTek MT7988 SoC comes with a built-in switch very similar to > previous MT7530 and MT7531. However, the switch address space is mapped > into the SoCs memory space rather than being connected via MDIO. > Using MMIO simplifies register access and also removes the need for a bus > lock, and for that reason also makes interrupt handling more light-weight. > > Note that this is different from previous SoCs like MT7621 and MT7623N > which also came with an integrated MT7530-like switch which yet had to be > accessed via MDIO. > > Split-off the part of the driver registering an MDIO driver, then add > another module acting as MMIO/platform driver. > > The whole series has been tested on various MediaTek boards: > * MT7623A + MT7530 (BPi-R2) > * MT7986A + MT7531 (BPi-R3) > * MT7988A reference board
You did not address the incorrect information I pointed out here. Now that the patch series is applied, people reading this on the merge branch commit will be misled by the misinformation.
> > Changes since v1: > * use 'internal' PHY mode where appropriate > * use regmap_update_bits in mt7530_rmw > * improve dt-bindings
As a maintainer of the said dt-bindings, I pointed out almost 7 things for you to change. Of those 7 points, you only did one, a trivial grammar change. The patch series is applied now so one of us maintainers (you are one too now) need to fix it with additional patches.
Arınç
| |